Fix ManifestEntry.snapshot_id setter writing to wrong index#3257
Open
lawofcycles wants to merge 1 commit intoapache:mainfrom
Open
Fix ManifestEntry.snapshot_id setter writing to wrong index#3257lawofcycles wants to merge 1 commit intoapache:mainfrom
lawofcycles wants to merge 1 commit intoapache:mainfrom
Conversation
The setter wrote to self._data[0] (status) instead of self._data[1] (snapshot_id), corrupting the status field and leaving snapshot_id unchanged when _inherit_from_manifest() assigned the inherited value. Signed-off-by: Sotaro Hikita <bering1814@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3256
Rationale for this change
The
snapshot_idproperty setter onManifestEntrywrites toself._data[0](thestatusfield) instead ofself._data[1](thesnapshot_idfield). This means that when_inherit_from_manifest()assigns a nullsnapshot_idfrom the manifest'sadded_snapshot_id, the entry'sstatusis corrupted andsnapshot_idremainsNone.Are these changes tested?
Yes. Added
test_inherit_from_manifest_snapshot_idto verify that_inherit_from_manifest()correctly inheritssnapshot_idwithout corrupting thestatusfield.Are there any user-facing changes?
N/A